Messages in this thread | | | Date | Mon, 10 Mar 2014 15:07:00 +0000 | From | Lee Jones <> | Subject | Re: [PATCH] drivers: mfd: silence compiler warning in sec-core.c |
| |
> When used 64bit compiler GCC warns as > drivers/mfd/sec-core.c:199:10: warning: > cast from pointer to integer of different size [-Wpointer-to-int-cast] > > This patch fixes this by type-casting "match->data" into "long" before > converting into "int" > > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > --- > drivers/mfd/sec-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c > index a139798..2e7580bd 100644 > --- a/drivers/mfd/sec-core.c > +++ b/drivers/mfd/sec-core.c > @@ -187,7 +187,7 @@ static inline int sec_i2c_get_driver_data(struct i2c_client *i2c, > if (i2c->dev.of_node) { > const struct of_device_id *match; > match = of_match_node(sec_dt_match, i2c->dev.of_node); > - return (int)match->data; > + return (int)(long)match->data;
I think using an unsigned long would be better.
> } > #endif > return (int)id->driver_data;
Doesn't this give you the same error?
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |