Messages in this thread | | | Date | Thu, 6 Feb 2014 13:48:12 +0100 | Subject | Re: [PATCH] pinctrl: do not init debugfs entries for unimplemented functionalities | From | Linus Walleij <> |
| |
On Wed, Feb 5, 2014 at 7:51 AM, Florian Vaussard <florian.vaussard@epfl.ch> wrote:
> Commit c420619 "pinctrl: pinconf: remove checks on ops->pin_config_get" > removed the check on (ops != NULL) when performing pinconf_pins_show() or > pinconf_groups_show(). As these entries are always enabled, even if > pinconf is not supported, reading will result in an oops due to NULL > ops. > > Instead of checking for ops, remove the corresponding debugfs entries if > pinconf and/or pinmux are not implemented. > > Tested on OMAP3 (pinctrl-single). > > Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
Oh that was an elegant fix, thanks! Patch applied for fixes, tagged for stable.
Yours, Linus Walleij
| |