lkml.org 
[lkml]   [2014]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] pinctrl: do not init debugfs entries for unimplemented functionalities
From
On Wed, Feb 5, 2014 at 7:51 AM, Florian Vaussard
<florian.vaussard@epfl.ch> wrote:

> Commit c420619 "pinctrl: pinconf: remove checks on ops->pin_config_get"
> removed the check on (ops != NULL) when performing pinconf_pins_show() or
> pinconf_groups_show(). As these entries are always enabled, even if
> pinconf is not supported, reading will result in an oops due to NULL
> ops.
>
> Instead of checking for ops, remove the corresponding debugfs entries if
> pinconf and/or pinmux are not implemented.
>
> Tested on OMAP3 (pinctrl-single).
>
> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>

Oh that was an elegant fix, thanks!
Patch applied for fixes, tagged for stable.

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2014-02-06 14:21    [W:0.040 / U:2.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site