Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH 08/19] perf c2c: Shared data analyser | Date | Fri, 28 Feb 2014 11:08:59 -0800 |
| |
Don Zickus <dzickus@redhat.com> writes: > + > +static const struct perf_evsel_str_handler handlers[] = { > + { "cpu/mem-loads,ldlat=30/pp", perf_c2c__process_load, }, > + { "cpu/mem-stores/pp", perf_c2c__process_store, },
The 30 magic number should probably be configurable.
Using load-latency here rules out Atom, so at some point you would need to get rid of that.
I suspect on most systems you should rather use p instead of pp to get the overhead down (before Haswell pp is expensive)
> +static int perf_c2c__record(int argc, const char **argv) > +{ > + unsigned int rec_argc, i, j; > + const char **rec_argv; > + const char * const record_args[] = { > + "record", > + /* "--phys-addr", */
So is that needed or not?
-Andi -- ak@linux.intel.com -- Speaking for myself only
| |