lkml.org 
[lkml]   [2014]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 08/19] perf c2c: Shared data analyser
    Date
    Don Zickus <dzickus@redhat.com> writes:
    > +
    > +static const struct perf_evsel_str_handler handlers[] = {
    > + { "cpu/mem-loads,ldlat=30/pp", perf_c2c__process_load, },
    > + { "cpu/mem-stores/pp", perf_c2c__process_store, },

    The 30 magic number should probably be configurable.

    Using load-latency here rules out Atom, so at some point
    you would need to get rid of that.

    I suspect on most systems you should rather use p
    instead of pp to get the overhead down (before Haswell pp
    is expensive)

    > +static int perf_c2c__record(int argc, const char **argv)
    > +{
    > + unsigned int rec_argc, i, j;
    > + const char **rec_argv;
    > + const char * const record_args[] = {
    > + "record",
    > + /* "--phys-addr", */

    So is that needed or not?

    -Andi
    --
    ak@linux.intel.com -- Speaking for myself only


    \
     
     \ /
      Last update: 2014-02-28 20:41    [W:4.714 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site