lkml.org 
[lkml]   [2014]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 03/19] perf, sort: Allow unique sorting instead of combining hist_entries
    Date
    The cache contention tools needs to keep all the perf records unique in order
    to properly parse all the data. Currently add_hist_entry() will combine
    the duplicate record and add the weight/period to the existing record.

    This throws away the unique data the cache contention tool needs (mainly
    the data source). Create a flag to force the records to stay unique.

    Signed-off-by: Don Zickus <dzickus@redhat.com>
    ---
    tools/perf/util/hist.c | 3 ++-
    tools/perf/util/sort.c | 1 +
    tools/perf/util/sort.h | 1 +
    3 files changed, 4 insertions(+), 1 deletion(-)

    diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
    index ea54db3..cf85d7d 100644
    --- a/tools/perf/util/hist.c
    +++ b/tools/perf/util/hist.c
    @@ -365,7 +365,8 @@ static struct hist_entry *add_hist_entry(struct hists *hists,
    */
    cmp = hist_entry__cmp(he, entry);

    - if (!cmp) {
    + if (!cmp && !sort__wants_unique) {
    +
    he_stat__add_period(&he->stat, period, weight);

    /*
    diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
    index 0cb43a5..453b8f0 100644
    --- a/tools/perf/util/sort.c
    +++ b/tools/perf/util/sort.c
    @@ -14,6 +14,7 @@ int sort__need_collapse = 0;
    int sort__has_parent = 0;
    int sort__has_sym = 0;
    int sort__has_dso = 0;
    +int sort__wants_unique = 0;
    enum sort_mode sort__mode = SORT_MODE__NORMAL;

    enum sort_type sort__first_dimension;
    diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h
    index eb8cd50..4e960fd 100644
    --- a/tools/perf/util/sort.h
    +++ b/tools/perf/util/sort.h
    @@ -33,6 +33,7 @@ extern int have_ignore_callees;
    extern int sort__need_collapse;
    extern int sort__has_parent;
    extern int sort__has_sym;
    +extern int sort__wants_unique;
    extern enum sort_mode sort__mode;
    extern struct sort_entry sort_comm;
    extern struct sort_entry sort_dso;
    --
    1.7.11.7


    \
     
     \ /
      Last update: 2014-02-28 20:01    [W:4.036 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site