Messages in this thread | | | Date | Thu, 27 Feb 2014 19:24:14 -0600 | Subject | Re: [PATCH] checkpatch: fix spurious vendor compatible warnings | From | Rob Herring <> |
| |
On Thu, Feb 27, 2014 at 5:53 PM, Joe Perches <joe@perches.com> wrote: > On Thu, 2014-02-27 at 21:24 +0100, Florian Vaussard wrote: >> On 02/27/2014 09:10 PM, Joe Perches wrote: >> > On Thu, 2014-02-27 at 20:56 +0100, Florian Vaussard wrote: >> >> With a compatible string like >> >> compatible = "foo"; >> >> checkpatch will currently try to find "foo" in vendor-prefixes.txt, >> >> which is wrong since the vendor prefix is empty in this specific case. > [] >> > Some vendor names have dashes. >> > I don't know if underscores are allowed. >> > >> > $ grep -rP --include=*.[ch] -oh "compatible\s*=\s*\"[^,]+,\w" * | \ >> > sed -r -e 's/\s//g' -e 's/,.$//' | sort | uniq -c | grep "[_-]" >> > 1 compatible="active-semi >> > 8 compatible="asahi-kasei > [] >> In ePAPR v1.1, I could not find any strict requirement. It >> is just saying: >> >> The recommended format is "manufacturer,model", where manufacturer is a >> string describing the name of the manufacturer (such as a stock ticker >> symbol), and model specifies the model number. > > Should there also be a check in .c and .h files for > .compatible = "somestring"
Ideally, yes. I didn't do that because I figured there would be too many variations in formatting compared to dts files.
> and > OF_DEV_AUXDATA("somestring",,,,)
Probably not. OF_DEV_AUXDATA is hopefully temporary. There are 156 instances now and it looks like they've been going down since 3.8.
Rob
| |