Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 1/7] IBM Akebono: Add a SDHCI platform driver | Date | Fri, 21 Feb 2014 15:14:30 +0100 |
| |
On Friday 21 February 2014 17:31:27 Alistair Popple wrote:
> > +config MMC_SDHCI_OF_476GTR > + tristate "SDHCI OF support for the IBM PPC476GTR SoC" > + depends on MMC_SDHCI_PLTFM > + depends on PPC_OF > + help > + This selects the Secure Digital Host Controller Interface (SDHCI) > + found on the PPC476GTR SoC. > + > + If you have a controller with this interface, say Y or M here. > + > + If unsure, say N.
Your driver doesn't actually do anything beyond what is in the common sdhci-pltfm.c infrastructure. IMHO you really shoulnd't need a SoC specific abstraction for it at all and instead add a generic platform driver registration into sdhci-pltfm.c. I'd suggest you use "generic-sdhci" (similar to what we do for usb-ohci and usb-ehci now) as the compatible string and change your device tree to claim compatibility with that and your soc-specific string.
Arnd
| |