lkml.org 
[lkml]   [2014]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.11 087/121] xen-blkfront: handle backend CLOSED without CLOSING
    Date
    3.11.10.5 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: David Vrabel <david.vrabel@citrix.com>

    commit 3661371701e714f0cea4120f6a365340858fb4e4 upstream.

    Backend drivers shouldn't transistion to CLOSED unless the frontend is
    CLOSED. If a backend does transition to CLOSED too soon then the
    frontend may not see the CLOSING state and will not properly shutdown.

    So, treat an unexpected backend CLOSED state the same as CLOSING.

    Signed-off-by: David Vrabel <david.vrabel@citrix.com>
    Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/block/xen-blkfront.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
    index ed88b3c..e85bc35 100644
    --- a/drivers/block/xen-blkfront.c
    +++ b/drivers/block/xen-blkfront.c
    @@ -1852,13 +1852,16 @@ static void blkback_changed(struct xenbus_device *dev,
    case XenbusStateReconfiguring:
    case XenbusStateReconfigured:
    case XenbusStateUnknown:
    - case XenbusStateClosed:
    break;

    case XenbusStateConnected:
    blkfront_connect(info);
    break;

    + case XenbusStateClosed:
    + if (dev->state == XenbusStateClosed)
    + break;
    + /* Missed the backend's Closing state -- fallthrough */
    case XenbusStateClosing:
    blkfront_closing(info);
    break;
    --
    1.9.0


    \
     
     \ /
      Last update: 2014-02-21 15:41    [W:3.327 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site