| Date | Mon, 17 Feb 2014 16:23:01 -0800 | From | Josh Triplett <> | Subject | Re: [PATCH tip/core/rcu 17/55] rcutorture: Abstract torture_param() |
| |
On Mon, Feb 17, 2014 at 02:12:21PM -0800, Paul E. McKenney wrote: > From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> > > Create a torture_param() macro and apply it to rcutorture in order to > save a few lines of code. This same macro may be applied to other > torture frameworks. > > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Your commit message says "torture_param", but your code says "torture_parm". Let's go with the former, please; no need to creat more disemvoweled abbreviations.
Also, this seems rather generally useful. A quick check with "git grep -B2 MODULE_PARM_DESC" turns up numerous instances of the pattern. You might consider adding this as a helper DECLARE_MODULE_PARAM_RO in include/linux/moduleparam.h (possibly calling a generalized version that takes the mode as another parameter).
- Josh Triplett
|