lkml.org 
[lkml]   [2014]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH]sched/deadline: Remove useless dl_nr_total
    Date
    In deadline class we do not have group scheduling like in RT.

    dl_nr_total is the same as dl_nr_running. So, one of them should
    be removed.

    Signed-off-by: Kirill Tkhai <tkhai@yandex.ru>
    CC: Juri Lelli <juri.lelli@gmail.com>
    CC: Peter Zijlstra <peterz@infradead.org>
    CC: Ingo Molnar <mingo@redhat.com>
    ---
    kernel/sched/deadline.c | 4 +---
    kernel/sched/sched.h | 1 -
    2 files changed, 1 insertion(+), 4 deletions(-)
    diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
    index ed31ef6..7a0db95 100644
    --- a/kernel/sched/deadline.c
    +++ b/kernel/sched/deadline.c
    @@ -121,7 +121,7 @@ static inline void dl_clear_overload(struct rq *rq)

    static void update_dl_migration(struct dl_rq *dl_rq)
    {
    - if (dl_rq->dl_nr_migratory && dl_rq->dl_nr_total > 1) {
    + if (dl_rq->dl_nr_migratory && dl_rq->dl_nr_running > 1) {
    if (!dl_rq->overloaded) {
    dl_set_overload(rq_of_dl_rq(dl_rq));
    dl_rq->overloaded = 1;
    @@ -137,7 +137,6 @@ static void inc_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
    struct task_struct *p = dl_task_of(dl_se);
    dl_rq = &rq_of_dl_rq(dl_rq)->dl;

    - dl_rq->dl_nr_total++;
    if (p->nr_cpus_allowed > 1)
    dl_rq->dl_nr_migratory++;

    @@ -149,7 +148,6 @@ static void dec_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
    struct task_struct *p = dl_task_of(dl_se);
    dl_rq = &rq_of_dl_rq(dl_rq)->dl;

    - dl_rq->dl_nr_total--;
    if (p->nr_cpus_allowed > 1)
    dl_rq->dl_nr_migratory--;

    diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
    index 1bf34c2..6a00804 100644
    --- a/kernel/sched/sched.h
    +++ b/kernel/sched/sched.h
    @@ -444,7 +444,6 @@ struct dl_rq {
    } earliest_dl;

    unsigned long dl_nr_migratory;
    - unsigned long dl_nr_total;
    int overloaded;

    /*

    \
     
     \ /
      Last update: 2014-02-18 00:01    [W:3.885 / U:0.856 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site