Messages in this thread | | | Date | Fri, 14 Feb 2014 20:57:43 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v6] mfd: MAX6650/6651 support |
| |
On Fri, Feb 14, 2014 at 09:02:20AM +0000, Laszlo Papp wrote: > On Wed, Feb 12, 2014 at 5:50 PM, Mark Brown <broonie@kernel.org> wrote: > > On Wed, Feb 12, 2014 at 04:02:40AM +0000, Laszlo Papp wrote:
> >> +const struct regmap_config max665x_regmap_config = { > >> + .reg_bits = 5, > >> +};
> > This would normally be static too, and I'd *really* expect to see a > > val_bits set here. I'm a bit surprised this works without one.
> Makes sense, thanks. Shall I also set the .max_register or any other > mandatory variables in here?
It's better to set max_register since that makes the debug features of the regmap API more useful but it's not required, only reg_bits and val_bits are absolutely required. In general the more complete the description of the register map in the driver the better. [unhandled content-type:application/pgp-signature] | |