Messages in this thread | | | Date | Wed, 12 Feb 2014 22:54:37 +0100 | Subject | Re: [PATCH] of: Turn of_match_node into a static inline when CONFIG_OF isn't set | From | Geert Uytterhoeven <> |
| |
On Tue, Feb 11, 2014 at 9:06 PM, Arnd Bergmann <arnd@arndb.de> wrote: > On Tuesday 11 February 2014 19:29:19 Geert Uytterhoeven wrote: >> On Tue, Feb 11, 2014 at 7:08 PM, Josh Cartwright <joshc@codeaurora.org> wrote: >> Ideally, all xxx_device_id look like >> >> struct xxx_device_id { >> ... /* bus-specific ID information */ >> kernel_ulong_t driver_data; >> }; >> >> This may be formalized in some way, using a base class, but thay may >> require reordering the fields, like: >> >> struct base_device_id { >> kernel_ulong_t driver_data; >> long id[0]; >> }; >> > > You can't reorder the fields because they are shared with user > space in form of the module-init-tools.
Sure, that's part of the ABI.
But that doesn't mean we can't change the ID as stored in the platform_device. Many drivers don't want to know the ID, only the driver_data part. Having that in a uniform way across the different ID types would help.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |