Messages in this thread | | | Date | Tue, 11 Feb 2014 12:20:38 -0800 | From | Guenter Roeck <> | Subject | Re: [PATCH v2 07/11] watchdog: xilinx: Use of_property_read_u32 |
| |
On Tue, Feb 11, 2014 at 07:55:50AM +0100, Michal Simek wrote: > Use of_property_read_u32 functions to clean probe function. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > [ ... ]
> + > + if (enable_once) > watchdog_set_nowayout(xilinx_wdt_wdd, true); > - }
watchdog_set_nowayout(xilinx_wdt_wdd, enable_once);
would probably do as well (the function checks the flag as well).
Nitpick, so
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
| |