Messages in this thread | | | From | "" <> | Subject | RE: [PATCH 1/2] ASoC: fsl-spdif: big-endian support | Date | Tue, 11 Feb 2014 07:25:25 +0000 |
| |
> > + spdif_priv->big_endian = of_property_read_bool(np, "big-endian"); > > + if (spdif_priv->big_endian) > > + fsl_spdif_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG; > > Why not just: > if (of_property_read_bool(np, "big-endian")) > fsl_spdif_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG; >
I just think maybe other places of the driver maybe use this. Yes, it could be removed just for now.
See the next version please.
Thanks very much,
-- Best Regards, Xiubo
| |