lkml.org 
[lkml]   [2014]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/2] ASoC: fsl-spdif: big-endian support
Date
> > +	spdif_priv->big_endian = of_property_read_bool(np, "big-endian");
> > + if (spdif_priv->big_endian)
> > + fsl_spdif_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG;
>
> Why not just:
> if (of_property_read_bool(np, "big-endian"))
> fsl_spdif_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG;
>

I just think maybe other places of the driver maybe use this.
Yes, it could be removed just for now.

See the next version please.

Thanks very much,

--
Best Regards,
Xiubo



\
 
 \ /
  Last update: 2014-02-11 08:41    [W:0.170 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site