Messages in this thread | | | Date | Tue, 11 Feb 2014 17:26:25 +0100 | From | Michal Hocko <> | Subject | Re: [PATCH cgroup/for-3.14-fixes] cgroup: protect modifications to cgroup_idr with cgroup_mutex |
| |
On Tue 11-02-14 10:41:05, Tejun Heo wrote: [...] > @@ -4254,12 +4256,12 @@ static long cgroup_create(struct cgroup *parent, struct dentry *dentry, > > return 0; > > -err_unlock: > - mutex_unlock(&cgroup_mutex); > - /* Release the reference count that we took on the superblock */ > - deactivate_super(sb); > err_free_id: > idr_remove(&root->cgroup_idr, cgrp->id); > + /* Release the reference count that we took on the superblock */ > + deactivate_super(sb); > +err_unlock: > + mutex_unlock(&cgroup_mutex); > err_free_name: > kfree(rcu_dereference_raw(cgrp->name)); > err_free_cgrp:
Do I have to change deactivate_super vs. mutex_unlock ordering in my backport for 3.12 as well? -- Michal Hocko SUSE Labs
| |