lkml.org 
[lkml]   [2014]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 24/51] x86, hpet: Fix CPU hotplug callback registration
On 02/11/2014 12:28 AM, Gautham R Shenoy wrote:
> Hi,
>
> On Thu, Feb 06, 2014 at 03:39:00AM +0530, Srivatsa S. Bhat wrote:
>> diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
>> index da85a8e..199aaae 100644
>> --- a/arch/x86/kernel/hpet.c
>> +++ b/arch/x86/kernel/hpet.c
>> @@ -943,12 +943,14 @@ static __init int hpet_late_init(void)
>> if (boot_cpu_has(X86_FEATURE_ARAT))
>> return 0;
>>
>> + cpu_maps_update_begin();
>> for_each_online_cpu(cpu) {
>> hpet_cpuhp_notify(NULL, CPU_ONLINE, (void *)(long)cpu);
>> }
>>
>> /* This notifier should be called after workqueue is ready */
>> - hotcpu_notifier(hpet_cpuhp_notify, -20);
>> + __hotcpu_notifier(hpet_cpuhp_notify, -20);
>
> We could #define HPET_CPUHP_PRIO relative to the workqueue priority instead of
> hardcoding this it this way.
>

Sure, we can do that. Thanks for pointing that out!

Regards,
Srivatsa S. Bhat



\
 
 \ /
  Last update: 2014-02-11 08:21    [W:0.361 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site