lkml.org 
[lkml]   [2014]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of
    From
    On Tue, Feb 11, 2014 at 8:52 AM, Russell King - ARM Linux
    <linux@arm.linux.org.uk> wrote:
    > On Tue, Feb 11, 2014 at 07:56:33AM -0600, Rob Herring wrote:
    >> On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
    >> > This allows to reuse the same parser code from outside the V4L2 framework,
    >> > most importantly from display drivers. There have been patches that duplicate
    >> > the code (and I am going to send one of my own), such as
    >> > http://lists.freedesktop.org/archives/dri-devel/2013-August/043308.html
    >> > and others that parse the same binding in a different way:
    >> > https://www.mail-archive.com/linux-omap@vger.kernel.org/msg100761.html
    >> >
    >> > I think that all common video interface parsing helpers should be moved to a
    >> > single place, outside of the specific subsystems, so that it can be reused
    >> > by all drivers.
    >>
    >> Perhaps that should be done rather than moving to drivers/of now and
    >> then again to somewhere else.
    >
    > Do you have a better suggestion where it should move to?

    No.

    > drivers/gpu/drm - no, because v4l2 wants to use it
    > drivers/media/video - no, because DRM drivers want to use it
    > drivers/video - no, because v4l2 and drm drivers want to use it

    I don't believe it exists currently, so it would need to be created.
    Perhaps adding a layer of directory to combine these. This patch alone
    is not enough to really justify that, but if there's a lot more shared
    code possible then it would be the right direction.

    > Maybe drivers/of-graph/ ? Or maybe it's just as good a place to move it
    > into drivers/of ?

    I assume you weren't serious, but no for /of-graph. If a better place
    can't be found/made, I'll take it.

    Rob


    \
     
     \ /
      Last update: 2014-02-14 18:01    [W:3.920 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site