Messages in this thread | | | Subject | Re: [PATCH 1/4] Make vsyscall_gtod_data handling x86 generic | From | Stefani Seibold <> | Date | Sat, 01 Feb 2014 15:51:24 +0100 |
| |
Am Donnerstag, den 30.01.2014, 16:10 -0800 schrieb Andi Kleen: > > @@ -1335,7 +1335,6 @@ config ARCH_SPARSEMEM_ENABLE > > > > config ARCH_SPARSEMEM_DEFAULT > > def_bool y > > - depends on X86_64 > > Is that really needed? Why does the vdso need sparsemem? >
No, it is from the previous patch. I will fix it.
> > > > static inline void __user *arch_compat_alloc_user_space(long len) > > { > > +#ifdef CONFIG_X86_32 > > + struct pt_regs *regs = task_pt_regs(current); > > + return (void __user *)regs->sp - len; > > +#else > > compat_uptr_t sp; > > and that? why does a vdso need to allocate things on the user page? >
Will also fixed, compat.h will not longer include by vsyscall_gtod.c.
| |