lkml.org 
[lkml]   [2014]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/4] mm/compaction: fix wrong order check in compact_finished()
    Date
    What we want to check here is whether there is highorder freepage
    in buddy list of other migratetype in order to steal it without
    fragmentation. But, current code just checks cc->order which means
    allocation request order. So, this is wrong.

    Without this fix, non-movable synchronous compaction below pageblock order
    would not stopped until compaction is complete, because migratetype of most
    pageblocks are movable and high order freepage made by compaction is usually
    on movable type buddy list.

    There is some report related to this bug. See below link.

    http://www.spinics.net/lists/linux-mm/msg81666.html

    Although the issued system still has load spike comes from compaction,
    this makes that system completely stable and responsive according to
    his report.

    stress-highalloc test in mmtests with non movable order 7 allocation doesn't
    show any notable difference in allocation success rate, but, it shows more
    compaction success rate and reduced elapsed time.

    Compaction success rate (Compaction success * 100 / Compaction stalls, %)
    18.47 : 28.94

    Elapsed time (sec)
    1429 : 1411

    Cc: <stable@vger.kernel.org>
    Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
    ---
    mm/compaction.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/mm/compaction.c b/mm/compaction.c
    index c9ee464..1a5f465 100644
    --- a/mm/compaction.c
    +++ b/mm/compaction.c
    @@ -1105,7 +1105,7 @@ static int __compact_finished(struct zone *zone, struct compact_control *cc,
    return COMPACT_PARTIAL;

    /* Job done if allocation would set block type */
    - if (cc->order >= pageblock_order && area->nr_free)
    + if (order >= pageblock_order && area->nr_free)
    return COMPACT_PARTIAL;
    }

    --
    1.7.9.5


    \
     
     \ /
      Last update: 2014-12-08 08:41    [W:4.260 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site