lkml.org 
[lkml]   [2014]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BUG] kzalloc overflow in lpfc driver on 6k core system
On Tue, Dec 02, 2014 at 10:39:40PM +0000, Elliott, Robert (Server Storage) wrote:
> In similar code, mpt3sas and lockless hpsa just call get_cpu_mask()
> inside the loop:
> cpu = cpumask_first(cpu_online_mask);
> for (i = 0; i < h->msix_vector; i++) {
> rc = irq_set_affinity_hint(h->intr[i], get_cpu_mask(cpu));
> cpu = cpumask_next(cpu, cpu_online_mask);
> }
>
> get_cpu_mask() uses the global cpu_bit_bitmap array, which is declared
> in kernel/cpu.c:
> extern const unsigned long
> cpu_bit_bitmap[BITS_PER_LONG+1][BITS_TO_LONGS(NR_CPUS)];
>
> That approach should work for lpfc.

Ok, good deal. Thanks for the info, Robert. Do you know who the
current maintainer is for this code? Would that be you? I included the
two authors that get_maintainer reported, but haven't heard from them.

I like this approach and don't mind implementing it myself, but I'd like
to confirm that whoever would be responsible for merging the code is ok
with the change before going forward. Of course, if the code has been
orphaned, then I guess we just write away :)

Thanks again for the help!

- Alex


\
 
 \ /
  Last update: 2014-12-03 17:41    [W:0.350 / U:1.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site