Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH] net: wireless: rtlwifi: rtl8192de: fw.c: Remove unused function | Date | Wed, 24 Dec 2014 17:23:01 +0200 |
| |
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> writes:
> Remove the function rtl92d_set_fw_pwrmode_cmd() that is not used anywhere. > > This was partially found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Thanks, applied to wireless-drivers-next.git.
But in the future, to make my work easier, please simplify your patch titles. You do not have to put the full directory structure there. I now manually changed it to:
commit 18e0c0bf3a5ea0f54384149570274d535341dc06 Author: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Date: Sun Dec 7 23:00:13 2014 +0100
rtlwifi: rtl8192de: fw.c: Remove unused function
Most important is that the title begins with the name of the driver (rtlwifi, iwlwifi, ath9k and so on) and is not too long. That way it's a lot easier for me and Johannes to manage the wireless patches in patchwork.
-- Kalle Valo
| |