lkml.org 
[lkml]   [2014]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] clk-rcar-gen2: RCAN clock support
    Hello.

    On 07/31/2014 12:23 AM, Sergei Shtylyov wrote:

    > Add RCAN clock support to the R-Car generation 2 CPG driver. This clock gets
    > derived from the USB_EXTAL clock by dividing it by 6. The layout of RCANCKCR
    > register is close to those of the clocks supported by the 'clk-div6' driver
    > but has no divider field, and so can't be supported by that driver...

    > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

    > ---
    > The patch is against the 'clk-next' branch of Mike Turquette's 'linux.git' repo.
    >
    > drivers/clk/shmobile/clk-rcar-gen2.c | 99 +++++++++++++++++++++++++++++++++++
    > 1 file changed, 99 insertions(+)

    > Index: linux/drivers/clk/shmobile/clk-rcar-gen2.c
    > ===================================================================
    > --- linux.orig/drivers/clk/shmobile/clk-rcar-gen2.c
    > +++ linux/drivers/clk/shmobile/clk-rcar-gen2.c
    [...]
    > +static struct clk * __init cpg_rcan_clk_register(struct rcar_gen2_cpg *cpg,
    > + struct device_node *np)
    > +{
    > + static const char *parent_name;

    No need for this *static*...

    > + struct clk_init_data init;
    > + struct cpg_rcan_clk *rcanclk;
    > + struct clk *clk;
    > +
    > + rcanclk = kzalloc(sizeof(*rcanclk), GFP_KERNEL);
    > + if (!rcanclk)
    > + return ERR_PTR(-ENOMEM);
    > +
    > + parent_name = of_clk_get_parent_name(np, 1);
    > +
    > + init.name = "rcan";
    > + init.ops = &cpg_rcan_clk_ops;
    > + init.parent_names = &parent_name;
    > + init.num_parents = 1;

    Ugh, forgot to clear the 'init.flags', so that it has some random value...

    WBR, Sergei



    \
     
     \ /
      Last update: 2014-12-24 00:41    [W:4.138 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site