Messages in this thread | | | Date | Sun, 21 Dec 2014 10:27:34 -0800 | From | Guenter Roeck <> | Subject | Re: [PATCH v4] i8k: Autodetect maximal fan speed and fan RPM multiplier |
| |
On 12/21/2014 09:23 AM, Pali Rohár wrote: > This patch adds new function i8k_get_fan_nominal_speed() for doing SMM call > which will return nominal fan RPM for specified fan speed. It returns nominal > RPM value at which fan operate when speed (0, 1, 2, 3) is set. It looks like > RPM value is not accurate, but still provides very useful information. > > First it can be used to validate if certain fan speed could be accepted by SMM > for setting fan speed and we can use this routine to detect maximal fan speed. > > Second it returns RPM value, so we can check if value looks correct with > multiplier 30 or multiplier 1 (until now only these two multiplier were used). > If RPM value with multiplier 30 is too high, then multiplier 1 is used. > > In case when SMM reports that new function is not supported we will fallback > to old hardcoded values. Maximal fan speed would be 2 and RPM multiplier 30. > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> > Tested-by: Pali Rohár <pali.rohar@gmail.com>
Tested-by the submitter is kind of implied.
Anyway, this patch does not apply to 3.19-rc1, nor to 3.18. What is your baseline ? Can you rebase to 3.19-rc1 ? Or do I need to apply some other patch first ?
Thanks, Guenter
| |