Messages in this thread | | | Date | Sun, 21 Dec 2014 00:52:05 -0800 | From | Jeremiah Mahler <> | Subject | Re: [PATCH] kernel: fixed a space coding style issue |
| |
Gangadhar,
On Sun, Dec 21, 2014 at 02:02:02PM +0530, Gangadhar Vukkesala wrote: > fixed a space coding style issue in pid.c which was found when > running checkpatch.pl on pid.c > > Signed-off-by: Gangadhar Vukkesala <gangs.freelancer@gmail.com> > --- > kernel/pid.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/pid.c b/kernel/pid.c > index cd36a5e..ad9d780 100644 > --- a/kernel/pid.c > +++ b/kernel/pid.c > @@ -72,7 +72,7 @@ struct pid_namespace init_pid_ns = { > .refcount = ATOMIC_INIT(2), > }, > .pidmap = { > - [ 0 ... PIDMAP_ENTRIES-1] = { ATOMIC_INIT(BITS_PER_PAGE), NULL } > + [0 ... PIDMAP_ENTRIES-1] = { ATOMIC_INIT(BITS_PER_PAGE), NULL } > }, > .last_pid = 0, > .nr_hashed = PIDNS_HASH_ADDING, > @@ -267,7 +267,7 @@ void free_pid(struct pid *pid) > struct upid *upid = pid->numbers + i; > struct pid_namespace *ns = upid->ns; > hlist_del_rcu(&upid->pid_chain); > - switch(--ns->nr_hashed) { > + switch (--ns->nr_hashed) { > case 2: > case 1: > /* When all that is left in the pid namespace > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
It looks reasonable. But keep in mind that white space fixes may be considered "code churn" [1] in some parts of the kernel. The staging area is much more welcoming of these sorts of changes.
[1]: https://lkml.org/lkml/2014/6/10/819
-- - Jeremiah Mahler
| |