Messages in this thread | | | Date | Sat, 20 Dec 2014 15:45:32 +0100 | From | SF Markus Elfring <> | Subject | Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks |
| |
> I'm saying to leave the code alone.
Do I need to try another interpretation out for your feedback?
> If it goes: > > var = foo_that_returns_ptr_err() > if (IS_ERR(var)) > return PTR_ERR(var); > > p->bar = var; > > or whatever, simply keep it that way!
Do you want to express here that a data structure member should only be set after a previous function call succeeded?
> I'm not engaging in this conversation any further, you have > already consumed way too much of my limited time on this > incredibly trivial matter.
I hope that you will find a bit time and patience again to clarify affected implementation details in a safer and unambiguous way.
Regards, Markus
| |