Messages in this thread | | | Date | Sat, 20 Dec 2014 06:13:37 +0000 | From | Al Viro <> | Subject | Re: [PATCH v2 4/5] swapfile: use ->read_iter and ->write_iter |
| |
On Fri, Dec 19, 2014 at 07:18:28PM -0800, Omar Sandoval wrote:
> + ret = swap_file->f_op->read_iter(&kiocb, &to); > + if (ret == PAGE_SIZE) { > + SetPageUptodate(page); > count_vm_event(PSWPIN); > + ret = 0; > + } else { > + ClearPageUptodate(page); > + SetPageError(page); > + } > + unlock_page(page);
Umm... What's to guarantee that ->read_iter() won't try lock_page() on what turns out to be equal to page?
| |