lkml.org 
[lkml]   [2014]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net: eth: xgene: change APM X-Gene SoC platform ethernet to support ACPI
From
From: Feng Kan <fkan@apm.com>
Date: Thu, 18 Dec 2014 15:39:51 -0800

> +#define NO_MAC_FOUND 0
> +#define RES_ENET_CSR 0
> +#define RES_RING_CSR 1
> +#define RES_RING_CMD 2

Don't define your own magic set of error return semantics.

For example, in the MAC address acquisition case, just verify that
you get an ETH_ALEN length value from the fetch routines and return
-ENODEV or similar if you do not.


\
 
 \ /
  Last update: 2014-12-19 19:01    [W:0.043 / U:1.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site