Messages in this thread | | | Date | Fri, 19 Dec 2014 12:31:07 -0500 (EST) | Subject | Re: [PATCH] net: eth: xgene: change APM X-Gene SoC platform ethernet to support ACPI | From | David Miller <> |
| |
From: Feng Kan <fkan@apm.com> Date: Thu, 18 Dec 2014 15:39:51 -0800
> +#define NO_MAC_FOUND 0 > +#define RES_ENET_CSR 0 > +#define RES_RING_CSR 1 > +#define RES_RING_CMD 2
Don't define your own magic set of error return semantics.
For example, in the MAC address acquisition case, just verify that you get an ETH_ALEN length value from the fetch routines and return -ENODEV or similar if you do not.
| |