lkml.org 
[lkml]   [2014]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] HID: logitech-hidpp: prefix the name with Logitech
    On Dec 17 2014 or thereabouts, Jiri Kosina wrote:
    > On Thu, 11 Dec 2014, Benjamin Tissoires wrote:
    >
    > > Current names are reported as "K750", "M705", and it can be misleading
    > > for the users when they look at their input device list.
    > >
    > > Prefixing the names with "Logitech " makes things better.
    > >
    > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
    > > ---
    > >
    > > Changes in v2:
    > > - renamed PREFIX_SIZE into PREFIX_LENGTH
    > > - changed "name_length + PREFIX_LENGTH;" into "PREFIX_LENGTH + name_length;"
    > > - rebased on Peter's last patch series
    >
    > Ok, looks reasonable. I was waiting whether someone from Logitech would
    > comment on the prefix check that could be used other than "Logitech".
    >
    > But we can add that later.
    >
    > Applied to for-3.20/logitech, thanks.
    >

    Hi Jiri,

    Thanks for applying most of the patches (2 are missing, I'll raise them
    in your inbox :-P )

    Regarding this one, I was wondering if we could not force it into 3.19,
    or at least add a stable@ tag. I had requested this in the first
    submission, and the rationale was to not change a third time the name of
    the device (from "Logitech Unifying Device. Wireless PID:XXXX" to
    "[TMK]XXX" to "Logitech [TMK]XXX").

    Userspace would be grateful to have a reliable name.

    Cheers,
    Benjamin


    \
     
     \ /
      Last update: 2014-12-17 17:01    [W:5.449 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site