lkml.org 
[lkml]   [2014]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [GIT PULL] tracing/NMI/printk: Use seq_buf for safe printing from NMI context
From
On Wed, Dec 10, 2014 at 8:20 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> Would it perhaps be possible/reasonable to also use this to get rid of
> the horrible "early_printk()" stuff [...]

Another question: the "preempt_disable/enable()" around the use of the
per-cpu vprintk_func thing seems dubious.

Why do I say that? I think it cannot possibly make sense. Anybody who
sets that function pointer to any per-cpu value has to disable
preemption for that to make sense, so doing it inside the printk()
paths seems dubious at best.

No?

Linus


\
 
 \ /
  Last update: 2014-12-11 07:01    [W:0.101 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site