lkml.org 
[lkml]   [2014]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 00/16] nfsd/sunrpc: add support for a workqueue-based nfsd
From
On Thu, Dec 11, 2014 at 6:12 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> Linus, do you see any problems with the following patch (against the mainline)?

Not concpetually, but create_kthread() uses CLONE_FS, and I don't
think it's just umask that things like nfsd want to avoid sharing.
What about all the *other* fields?

Just as an example: even if all the threads actually end up all having
the same global root, what about contention on 'fs->lock'?

I have *not* looked at the details, and maybe there's some reason I'm
completely off, but it worries me.

Linus


\
 
 \ /
  Last update: 2014-12-12 04:01    [W:0.208 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site