Messages in this thread | | | Date | Thu, 11 Dec 2014 20:40:30 +0000 | From | One Thousand Gnomes <> | Subject | Re: [PATCH socfpga-nex] staging: fpga manager: socfpga_fpga_ops can be static |
| |
On Thu, 11 Dec 2014 09:43:24 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:
> drivers/staging/fpga/socfpga.c:655:25: sparse: symbol 'socfpga_fpga_ops' was not declared. Should it be static? > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Ought to be const as well by the look of it - we don't want function pointers in patchable memory spaces.
| |