lkml.org 
[lkml]   [2014]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH socfpga-nex] staging: fpga manager: socfpga_fpga_ops can be static
On Thu, 11 Dec 2014 09:43:24 +0800
kbuild test robot <fengguang.wu@intel.com> wrote:

> drivers/staging/fpga/socfpga.c:655:25: sparse: symbol 'socfpga_fpga_ops' was not declared. Should it be static?
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Ought to be const as well by the look of it - we don't want function
pointers in patchable memory spaces.


\
 
 \ /
  Last update: 2014-12-11 22:21    [W:0.107 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site