Messages in this thread | | | Date | Thu, 11 Dec 2014 17:36:08 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c |
| |
On Wed, 10 Dec 2014, Yinghai Lu wrote: > On Wed, Dec 10, 2014 at 12:15 PM, Thomas Gleixner <tglx@linutronix.de> wrote: > >> - struct resource r = { > >> - .flags = 0 > >> - }; > >> + struct resource r; > >> > >> + memset(&r, 0, sizeof(r)); > > > > What's the point of this change? Both initialize r to 0. memset() > > generates better code, but that's irrelevant for the problem at hand. > > late there is > > info->res[info->res_num] = r; > > don't want the random pointer in r get copied.
Did you actually read what I wrote?
struct resource r = { .flags = 0 };
initializes r completely to 0. So how do you get a random pointer in r?
Thanks,
tglx
| |