lkml.org 
[lkml]   [2014]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/1] GPU-DRM-MSM: Deletion of unnecessary checks before two function calls
    From
    btw, I have these two queued up on msm-next, thanks

    BR,
    -R

    On Tue, Nov 25, 2014 at 8:33 AM, SF Markus Elfring
    <elfring@users.sourceforge.net> wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Tue, 25 Nov 2014 14:30:28 +0100
    >
    > The functions framebuffer_release() and vunmap() perform also input
    > parameter validation. Thus the test around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > drivers/gpu/drm/msm/msm_fbdev.c | 3 +--
    > drivers/gpu/drm/msm/msm_gem.c | 3 +--
    > 2 files changed, 2 insertions(+), 4 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
    > index ab5bfd2..fd5a6f3 100644
    > --- a/drivers/gpu/drm/msm/msm_fbdev.c
    > +++ b/drivers/gpu/drm/msm/msm_fbdev.c
    > @@ -193,8 +193,7 @@ fail_unlock:
    > fail:
    >
    > if (ret) {
    > - if (fbi)
    > - framebuffer_release(fbi);
    > + framebuffer_release(fbi);
    > if (fb) {
    > drm_framebuffer_unregister_private(fb);
    > drm_framebuffer_remove(fb);
    > diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
    > index 4b1b82a..157cf21 100644
    > --- a/drivers/gpu/drm/msm/msm_gem.c
    > +++ b/drivers/gpu/drm/msm/msm_gem.c
    > @@ -543,8 +543,7 @@ void msm_gem_free_object(struct drm_gem_object *obj)
    > drm_free_large(msm_obj->pages);
    >
    > } else {
    > - if (msm_obj->vaddr)
    > - vunmap(msm_obj->vaddr);
    > + vunmap(msm_obj->vaddr);
    > put_pages(obj);
    > }
    >
    > --
    > 2.1.3
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/


    \
     
     \ /
      Last update: 2014-12-01 17:41    [W:4.022 / U:1.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site