Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH perf/core 0/6] perf-probe: Bugfix and add new options for cache | Date | Tue, 04 Nov 2014 14:02:55 +0900 |
| |
Hi Arnaldo and Masami,
On Mon, 3 Nov 2014 14:19:00 -0200, Arnaldo Carvalho de Melo wrote: > [root@zoo ~]# perf buildid-cache --hell > Error: unknown option `hell' > > usage: perf buildid-cache [<options>] > > -a, --add <file list> > file(s) to add > -k, --kcore <file> kcore file to add > -r, --remove <file list> > file(s) to remove > -M, --missing <file> to find missing build ids in the cache > -f, --force don't complain, do it > -u, --update <file list> > file(s) to update > -v, --verbose be more verbose > > [root@zoo ~]# > > Already has support for yet another of content: kcore files, its just a matter of adding > one more: > > perf buildid-cache --probe
But it deals with binaries, and what we need is probe points. So maybe it's worth add a new command like:
perf probe-cache [add|del|enable|disable] [<options>] [<path>|<build-id>] <spec>... or perf probe-cache list [<options>]
This way we can handle both of kprobes and uprobes (so SDTs). What do you think?
Thanks, Namhyung
| |