Messages in this thread | | | Date | Thu, 27 Nov 2014 19:08:42 +0100 | From | David Hildenbrand <> | Subject | Re: [PATCH RFC 2/2] mm, sched: trigger might_sleep() in might_fault() when pagefaults are disabled |
| |
> > > - > > > - __might_sleep(__FILE__, __LINE__, 0); > > > + if (unlikely(!pagefault_disabled())) > > > + __might_sleep(__FILE__, __LINE__, 0); > > > > > Same here: so maybe make might_fault a wrapper > around __might_fault as well.
Yes, I also noticed that. It was part of the original code. For now I kept this revert as close as possible to the original patch.
Better fix this in an add-on patch? Or directly in this commit? At least for the in-header function it is easy to fix in this patch.
Thanks!
| |