lkml.org 
[lkml]   [2014]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH net] r8152: drop the tx packet with invalid length
    From
    From: Eric Dumazet <eric.dumazet@gmail.com>
    Date: Wed, 26 Nov 2014 08:52:28 -0800

    > On Wed, 2014-11-26 at 17:56 +0800, Hayes Wang wrote:
    >> Drop the tx packet which is more than the size of agg_buf_sz. When
    >> creating a bridge with the device, we may get the tx packet with
    >> TSO and the length is more than the gso_max_size which is set by
    >> the driver through netif_set_gso_max_size(). Such packets couldn't
    >> be transmitted and should be dropped directly.
    >>
    >> Signed-off-by: Hayes Wang <hayeswang@realtek.com>
    ...
    > Looks like a candidate for ndo_gso_check(), so that we do not drop, but
    > instead segment from netif_needs_gso()/validate_xmit_skb()

    You mean have the bridge implement the ndo_gso_check() method right?


    \
     
     \ /
      Last update: 2014-11-26 18:41    [W:2.922 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site