Messages in this thread | | | Date | Tue, 25 Nov 2014 07:55:34 +0200 | From | Brendan Hide <> | Subject | Re: [PATCH v2 5/5] btrfs: enable swap file support |
| |
On 2014/11/25 00:03, Omar Sandoval wrote: > [snip] > > The snapshot issue is a little tricker to resolve. I see a few options: > > 1. Just do the COW and hope for the best > 2. As part of btrfs_swap_activate, COW any shared extents. If a snapshot > happens while a swap file is active, we'll fall back to 1. > 3. Clobber any swap file extents which are in a snapshot, i.e., always use the > existing extent. > > I'm partial to 3, as it's the simplest approach, and I don't think it makes > much sense for a swap file to be in a snapshot anyways. I'd appreciate any > comments that anyone might have. > Personally, 3 seems pragmatic - but not necessarily "correct". :-/
-- __________ Brendan Hide http://swiftspirit.co.za/ http://www.webafrica.co.za/?AFF1E97
| |