lkml.org 
[lkml]   [2014]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] video: mx3fb: Deletion of an unnecessary check before the function call "backlight_device_unregister"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sun, 23 Nov 2014 15:15:29 +0100

    The backlight_device_unregister() function tests whether its argument is NULL
    and then returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/video/fbdev/mx3fb.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c
    index c645a0a..b2d2151 100644
    --- a/drivers/video/fbdev/mx3fb.c
    +++ b/drivers/video/fbdev/mx3fb.c
    @@ -334,8 +334,7 @@ static void mx3fb_init_backlight(struct mx3fb_data *fbd)

    static void mx3fb_exit_backlight(struct mx3fb_data *fbd)
    {
    - if (fbd->bl)
    - backlight_device_unregister(fbd->bl);
    + backlight_device_unregister(fbd->bl);
    }

    static void mx3fb_dma_done(void *);
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-23 16:01    [W:4.020 / U:1.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site