lkml.org 
[lkml]   [2014]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] video: udlfb: Deletion of unnecessary checks before the function call "vfree"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sun, 23 Nov 2014 11:40:47 +0100

    The vfree() function performs also input parameter validation. Thus the test
    around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/video/fbdev/udlfb.c | 9 +++------
    1 file changed, 3 insertions(+), 6 deletions(-)

    diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c
    index 77b890e..01fff0c 100644
    --- a/drivers/video/fbdev/udlfb.c
    +++ b/drivers/video/fbdev/udlfb.c
    @@ -922,8 +922,7 @@ static void dlfb_free(struct kref *kref)
    {
    struct dlfb_data *dev = container_of(kref, struct dlfb_data, kref);

    - if (dev->backing_buffer)
    - vfree(dev->backing_buffer);
    + vfree(dev->backing_buffer);

    kfree(dev->edid);

    @@ -953,8 +952,7 @@ static void dlfb_free_framebuffer(struct dlfb_data *dev)
    fb_dealloc_cmap(&info->cmap);
    if (info->monspecs.modedb)
    fb_destroy_modedb(info->monspecs.modedb);
    - if (info->screen_base)
    - vfree(info->screen_base);
    + vfree(info->screen_base);

    fb_destroy_modelist(&info->modelist);

    @@ -1203,8 +1201,7 @@ static int dlfb_realloc_framebuffer(struct dlfb_data *dev, struct fb_info *info)
    if (!new_back)
    pr_info("No shadow/backing buffer allocated\n");
    else {
    - if (dev->backing_buffer)
    - vfree(dev->backing_buffer);
    + vfree(dev->backing_buffer);
    dev->backing_buffer = new_back;
    }
    }
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-23 12:21    [W:4.020 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site