Messages in this thread | | | Date | Mon, 3 Nov 2014 00:21:39 +0000 | From | Al Viro <> | Subject | Re: fs: Use non-const iov in aio_read/aio_write |
| |
On Mon, Nov 03, 2014 at 12:16:34AM +0000, Al Viro wrote:
> NAK with extreme prejudice. The right way to deal with that is > to convert the socket side of things to iov_iter. And give it a > consistent behaviour, while we are at it (some protocols do advance > the damn thing, so do not). There are _very_ good reasons to have those > iovecs unchanged - if you look at the callers on the socket side, you'll > see a bunch that has to _copy_ iovec just to avoid it being buggered. > And you get rather suboptimal behaviour in memcpy_fromiovec() and friends, > exactly because you have to skip through the emptied elements. > > IOW, no way in hell.
PS: I do have the beginning of that stuff sitting in the local queue since April; see http://marc.info/?l=linux-xfs&m=139179304710494&w=2 for the beginning of the story.
| |