lkml.org 
[lkml]   [2014]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] keys: Deletion of an unnecessary check before the function call "key_put"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Tue, 18 Nov 2014 21:57:14 +0100

    The key_put() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    security/keys/process_keys.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/security/keys/process_keys.c b/security/keys/process_keys.c
    index 0cf8a13..ce00e11 100644
    --- a/security/keys/process_keys.c
    +++ b/security/keys/process_keys.c
    @@ -242,8 +242,7 @@ int install_session_keyring_to_cred(struct cred *cred, struct key *keyring)
    old = cred->session_keyring;
    rcu_assign_pointer(cred->session_keyring, keyring);

    - if (old)
    - key_put(old);
    + key_put(old);

    return 0;
    }
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-18 22:41    [W:4.209 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site