lkml.org 
[lkml]   [2014]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[RFC][PATCH 05/23 v4] tracing: Have branch tracer use trace_handle_return() helper function
    From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>

    The branch tracer should not be checking the trace_seq_printf() return value
    as that will soon be void. There's a new trace_handle_return() helper function
    that will return TRACE_TYPE_PARTIAL_LINE if the trace_seq overflowed
    and TRACE_TYPE_HANDLED otherwise.

    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    ---
    kernel/trace/trace_branch.c | 15 +++++++--------
    1 file changed, 7 insertions(+), 8 deletions(-)

    diff --git a/kernel/trace/trace_branch.c b/kernel/trace/trace_branch.c
    index 697fb9bac8f0..42c85036fc3f 100644
    --- a/kernel/trace/trace_branch.c
    +++ b/kernel/trace/trace_branch.c
    @@ -151,14 +151,13 @@ static enum print_line_t trace_branch_print(struct trace_iterator *iter,

    trace_assign_type(field, iter->ent);

    - if (trace_seq_printf(&iter->seq, "[%s] %s:%s:%d\n",
    - field->correct ? " ok " : " MISS ",
    - field->func,
    - field->file,
    - field->line))
    - return TRACE_TYPE_PARTIAL_LINE;
    -
    - return TRACE_TYPE_HANDLED;
    + trace_seq_printf(&iter->seq, "[%s] %s:%s:%d\n",
    + field->correct ? " ok " : " MISS ",
    + field->func,
    + field->file,
    + field->line);
    +
    + return trace_handle_return(&iter->seq);
    }

    static void branch_print_header(struct seq_file *s)
    --
    2.1.1



    \
     
     \ /
      Last update: 2014-11-14 04:01    [W:4.109 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site