Messages in this thread Patch in this message | | | From | Johan Hovold <> | Subject | [PATCH 09/22] net: phy: micrel: add led-mode sanity check | Date | Tue, 11 Nov 2014 18:37:27 +0100 |
| |
Make sure never to update more than two bits when setting the led mode, something which could for example change the reference-clock setting.
Signed-off-by: Johan Hovold <johan@kernel.org> --- drivers/net/phy/micrel.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 16135ac18bfe..1b3985cdc64c 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -173,6 +173,11 @@ static int kszphy_setup_led(struct phy_device *phydev, if (of_property_read_u32(of_node, "micrel,led-mode", &val)) return 0; + if (val > 3) { + dev_err(&phydev->dev, "invalid led mode: 0x%02x\n", val); + return -EINVAL; + } + temp = phy_read(phydev, reg); if (temp < 0) return temp; -- 2.0.4
| |