Messages in this thread Patch in this message | | | Subject | Re: [PATCH] x86, cpu: trivial printk formatting fixes | From | Joe Perches <> | Date | Sat, 01 Nov 2014 10:17:53 -0700 |
| |
On Sat, 2014-11-01 at 15:44 +0000, Steven Honeyman wrote: > A 2 line printk makes dmesg output messy, because the second line does not get a timestamp. > For example: [] > diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c [] > @@ -487,10 +487,8 @@ static void init_intel(struct cpuinfo_x86 *c) > > rdmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb); > if ((epb & 0xF) == ENERGY_PERF_BIAS_PERFORMANCE) { > - printk_once(KERN_WARNING "ENERGY_PERF_BIAS:" > - " Set to 'normal', was 'performance'\n" > - "ENERGY_PERF_BIAS: View and update with" > - " x86_energy_perf_policy(8)\n"); > + pr_info_once("ENERGY_PERF_BIAS: Set to 'normal', was 'performance'\n"); > + pr_info_once("ENERGY_PERF_BIAS: View and update with x86_energy_perf_policy(8)\n");
This changes the logging level.
You should either mention why in the changelog or use pr_warn_once
| |