lkml.org 
[lkml]   [2014]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 054/102] iscsi-target: avoid NULL pointer in iscsi_copy_param_list failure
    3.2.64-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Joern Engel <joern@logfs.org>

    commit 8ae757d09c45102b347a1bc2867f54ffc1ab8fda upstream.

    In iscsi_copy_param_list() a failed iscsi_param_list memory allocation
    currently invokes iscsi_release_param_list() to cleanup, and will promptly
    trigger a NULL pointer dereference.

    Instead, go ahead and return for the first iscsi_copy_param_list()
    failure case.

    Found by coverity.

    Signed-off-by: Joern Engel <joern@logfs.org>
    Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/target/iscsi/iscsi_target_parameters.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/target/iscsi/iscsi_target_parameters.c
    +++ b/drivers/target/iscsi/iscsi_target_parameters.c
    @@ -552,7 +552,7 @@ int iscsi_copy_param_list(
    param_list = kzalloc(sizeof(struct iscsi_param_list), GFP_KERNEL);
    if (!param_list) {
    pr_err("Unable to allocate memory for struct iscsi_param_list.\n");
    - goto err_out;
    + return -1;
    }
    INIT_LIST_HEAD(&param_list->param_list);
    INIT_LIST_HEAD(&param_list->extra_response_list);


    \
     
     \ /
      Last update: 2014-11-02 00:01    [W:3.160 / U:0.628 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site