Messages in this thread | | | Date | Thu, 9 Oct 2014 14:46:45 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH] bcma: fix build when CONFIG_OF_ADDRESS is not set |
| |
On Thu, Oct 09, 2014 at 11:39:41PM +0200, Hauke Mehrtens wrote: > Commit 2101e533f41a ("bcma: register bcma as device tree driver") > introduces a hard dependency on OF_ADDRESS into the bcma driver. > OF_ADDRESS is specifically disabled for the sparc architecture. > This results in the following error when building sparc64:allmodconfig. > > drivers/bcma/main.c: In function 'bcma_of_find_child_device': > drivers/bcma/main.c:150:3: error: implicit declaration of function 'of_translate_address' > > Fixes: 2101e533f41a ("bcma: register bcma as device tree driver") > Reported-by: Guenter Roeck <linux@roeck-us.net> > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Much better than my patch.
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Also compile tested to make sure it fixes the build problem.
Guenter
> --- > drivers/bcma/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c > index d1656c2..1000955 100644 > --- a/drivers/bcma/main.c > +++ b/drivers/bcma/main.c > @@ -132,7 +132,7 @@ static bool bcma_is_core_needed_early(u16 core_id) > return false; > } > > -#ifdef CONFIG_OF > +#if defined(CONFIG_OF) && defined(CONFIG_OF_ADDRESS) > static struct device_node *bcma_of_find_child_device(struct platform_device *parent, > struct bcma_device *core) > { > -- > 1.9.1 >
| |