Messages in this thread | | | Date | Thu, 9 Oct 2014 09:21:17 -0500 | From | Felipe Balbi <> | Subject | Re: [PATCH] usb: gadget: f_fs: remove redundant ffs_data_get() |
| |
On Thu, Oct 09, 2014 at 09:41:16AM +0200, Robert Baldyga wrote: > During FunctionFS bind, ffs_data_get() function was called twice > (in functionfs_bind() and in ffs_do_functionfs_bind()), while on unbind > ffs_data_put() was called once (in functionfs_unbind() function). > In result refcount never reached value 0, and ffs memory resources has > been never released. > > Since ffs_data_get() call in ffs_do_functionfs_bind() is redundant > and not neccessary, we remove it to have equal number of gets ans puts, > and free allocated memory after refcount reach 0. > > Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
Which commit is this fixing ? does it deserve a stable backport ? How far back ?
-- balbi [unhandled content-type:application/pgp-signature] | |