Messages in this thread | | | Date | Mon, 6 Oct 2014 23:39:45 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH] target/file: fix inclusive vfs_fsync_range() end |
| |
On Mon, Oct 06, 2014 at 04:40:13PM -0700, Zach Brown wrote: > Both of the file target's calls to vfs_fsync_range() got the end offset > off by one. The range is inclusive, not exclusive. It would sync a bit > more data than was required. > > The sync path already tested the length of the range and fell back to > LLONG_MAX so I copied that pattern in the rw path. > > This is untested. I found the errors by inspection while following other > code.
Maybe it's time to move vfs_fsync_range to a more normal calling convention?
| |