Messages in this thread | | | Date | Tue, 7 Oct 2014 13:10:54 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v2 1/2] socfpga: hotplug: put cpu1 in wfi |
| |
On Wed 2014-10-01 14:38:23, atull@opensource.altera.com wrote: > From: Alan Tull <atull@opensource.altera.com> > > Use WFI when putting CPU1 to sleep. Don't hold CPU1 in reset > since that results in increased power consumption. > > Reset CPU1 briefly during CPU1 bootup. > > This has been tested for hotplug and suspend/resume and results > in no increased power consumption. > > Signed-off-by: Alan Tull <atull@opensource.altera.com>
It is nice to Cc people who commented ont the patch before.
> if (cpu1start_addr) { > + /* This will put CPU #1 into reset. */ > + __raw_writel(RSTMGR_MPUMODRST_CPU1, > + rst_manager_base_addr + SOCFPGA_RSTMGR_MODMPURST); > +
I thought conclusion was to use writel (not __raw variant) here?
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |