Messages in this thread | | | Date | Thu, 30 Oct 2014 08:57:40 -0500 | From | Felipe Balbi <> | Subject | Re: [PATCHv6 2/8] usb: dwc2: Move gadget probe function into platform code |
| |
On Tue, Oct 28, 2014 at 06:25:43PM -0500, dinguyen@opensource.altera.com wrote: > From: Dinh Nguyen <dinguyen@opensource.altera.com> > > This patch will aggregate the probing of gadget/hcd driver into platform.c. > The gadget probe funtion is converted into gadget_init that is now only > responsible for gadget only initialization. All the gadget resources is now
s/resources is/resources are
> handled by platform.c > > Since the host workqueue will not get initialized if the driver is configured > for peripheral mode only. Thus we need to check for wq_otg before calling > queue_work().
this period character in the middle of the sentence doesn't make sense, perhaps a comma is what you want ? The sentence can be improved too:
"Since the host workqueue will not get initialized if the drier is configured for peripheral mode only, we add a check for wq_otg before calling queue_work()."
> Also, we move spin_lock_init to common location for both host and gadget that > is either in platform.c or pci.c. > > We also ove suspend/resume code to common platform code, and update it to use > the new PM API (struct dev_pm_ops).
updating to dev_pm_ops should really be a separate patch.
-- balbi [unhandled content-type:application/pgp-signature] | |