Messages in this thread | | | Date | Wed, 29 Oct 2014 16:41:47 +0900 | From | Alexandre Courbot <> | Subject | Re: [PATCH] ACPI / GPIO: Pass index to acpi_get_gpiod_by_index() when using properties |
| |
On 10/29/2014 06:59 AM, Rafael J. Wysocki wrote: > On Tuesday, October 28, 2014 01:15:27 PM Mika Westerberg wrote: >> acpi_dev_add_driver_gpios() makes it possible to set up mapping between >> properties and ACPI GpioIo resources in a driver, so we can take index >> parameter in acpi_find_gpio() into use with _DSD device properties now. >> >> This index can be used to select a GPIO from a property with multiple >> GPIOs: >> >> Package () { >> "data-gpios", >> Package () { >> \_SB.GPIO, 0, 0, 0, >> \_SB.GPIO, 1, 0, 0, >> \_SB.GPIO, 2, 0, 1, >> } >> } >> >> In order to retrieve the last GPIO from a driver we can simply do: >> >> desc = devm_gpiod_get_index(dev, "data", 2); >> >> and so on. >> >> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > Cool. :-) > > Any objections anyone?
Looks good to me!
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
Since this looks like a bug fix, shouldn't this be squashed into the relevant patch of the device-properties set?
| |